From c04cd835106ea4ffbadbfadd2b08e5fe38db12c9 Mon Sep 17 00:00:00 2001 From: dgibson <dgibson@redhat.com> Date: Wed, 29 Oct 2014 05:04:06 +0100 Subject: [PATCH 08/48] vga: Remove some "should be done in BIOS" comments Message-id: <1414559050-21089-8-git-send-email-dgibson@redhat.com> Patchwork-id: 61981 O-Subject: [RHEL 7.1 qemu-kvm-rhev 07/11] vga: Remove some "should be done in BIOS" comments Bugzilla: 1146809 RH-Acked-by: Laszlo Ersek <lersek@redhat.com> RH-Acked-by: Paolo Bonzini <pbonzini@redhat.com> RH-Acked-by: Gerd Hoffmann <kraxel@redhat.com> Signed-off-by: David Gibson <dgibson@redhat.com> commit ace89b8ff21cc3fb20986a334e54e6e6a1ccf729 Author: Benjamin Herrenschmidt <benh@kernel.crashing.org> Date: Sun Jun 22 18:28:05 2014 +1000 vga: Remove some "should be done in BIOS" comments Not all platforms have a VGA BIOS, powerpc typically relies on using the DISPI interface to initialize the card. Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> Reviewed-by: David Gibson <david@gibson.dropbear.id.au> Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com> --- hw/display/vga.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/display/vga.c b/hw/display/vga.c index 139a3c9..4643eed 100644 --- a/hw/display/vga.c +++ b/hw/display/vga.c @@ -765,14 +765,13 @@ void vbe_ioport_write_data(void *opaque, uint32_t addr, uint32_t val) s->vbe_regs[VBE_DISPI_INDEX_ENABLE] |= VBE_DISPI_ENABLED; vbe_fixup_regs(s); - /* clear the screen (should be done in BIOS) */ + /* clear the screen */ if (!(val & VBE_DISPI_NOCLEARMEM)) { memset(s->vram_ptr, 0, s->vbe_regs[VBE_DISPI_INDEX_YRES] * s->vbe_line_offset); } - /* we initialize the VGA graphic mode (should be done - in BIOS) */ + /* we initialize the VGA graphic mode */ /* graphic mode + memory map 1 */ s->gr[VGA_GFX_MISC] = (s->gr[VGA_GFX_MISC] & ~0x0c) | 0x04 | VGA_GR06_GRAPHICS_MODE; @@ -805,7 +804,6 @@ void vbe_ioport_write_data(void *opaque, uint32_t addr, uint32_t val) (shift_control << 5); s->cr[VGA_CRTC_MAX_SCAN] &= ~0x9f; /* no double scan */ } else { - /* XXX: the bios should do that */ s->bank_offset = 0; } s->dac_8bit = (val & VBE_DISPI_8BIT_DAC) > 0; -- 1.8.3.1